Fix BufferUnderflowException#2524
Open
bautismal wants to merge 1 commit intoAtmosphere:atmosphere-3.xfrom
Open
Fix BufferUnderflowException#2524bautismal wants to merge 1 commit intoAtmosphere:atmosphere-3.xfrom
bautismal wants to merge 1 commit intoAtmosphere:atmosphere-3.xfrom
Conversation
jfarcand
requested changes
Mar 21, 2025
Member
jfarcand
left a comment
There was a problem hiding this comment.
@bautismal This is a great start. I would check if the bb.array() is large enough (using the limit), and fall back to your solution if not. What do you think?
Author
|
@jfarcand, Not sure what change you are suggesting? |
20ead11 to
95be683
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug for issue #2523